[do not review] chore(shim): Update shim-unsigned-* to 16.1 - #18474
[do not review] chore(shim): Update shim-unsigned-* to 16.1#18474Lynsey Rydberg (corvus-callidus) wants to merge 5 commits into
Conversation
|
/azp run |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
|
Hello, and thank you for opening this pull request! 👋🏼 We appreciate the contribution. We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Commits in this repo will typically be prefixed with Details: |
There was a problem hiding this comment.
Pull request overview
Updates x64 and aarch64 unsigned shim packages from 15.8 to 16.1 and adds Azure Linux Secure Boot/SBAT customization.
Changes:
- Pins updated Fedora shim sources and refreshes locks.
- Adds Azure Linux certificate and SBAT records.
- Removes unsupported IA32 output from x64.
Reviewed changes
Copilot reviewed 10 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/shim-unsigned-x64/shim-unsigned-x64.comp.toml |
Defines x64 pin and overlays. |
base/comps/shim-unsigned-aarch64/shim-unsigned-aarch64.comp.toml |
Defines aarch64 pin and overlays. |
locks/shim-unsigned-x64.lock |
Locks updated x64 source. |
locks/shim-unsigned-aarch64.lock |
Locks updated aarch64 source. |
specs/s/shim-unsigned-x64/sources |
Records 16.1 source checksum. |
specs/s/shim-unsigned-x64/shim-unsigned-x64.spec |
Renders x64 package changes. |
specs/s/shim-unsigned-x64/sbat.redhat.csv |
Removes obsolete static SBAT data. |
specs/s/shim-unsigned-x64/sbat.azurelinux.csv.in |
Adds templated x64 SBAT data. |
specs/s/shim-unsigned-aarch64/sources |
Records 16.1 source checksum. |
specs/s/shim-unsigned-aarch64/shim-unsigned-aarch64.spec |
Renders aarch64 package changes. |
specs/s/shim-unsigned-aarch64/sbat.redhat.csv |
Removes obsolete static SBAT data. |
specs/s/shim-unsigned-aarch64/sbat.azurelinux.csv.in |
Adds templated aarch64 SBAT data. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| [components.shim-unsigned-x64] | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "bacb81905ea6806b97b968527e5ca9b2e3f0f7b4" } | ||
| # Pin shim 16.1 to Fedora dist-git commit d355c62164bd48c6f47774fe04b0d730d892e006. | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "d355c62164bd48c6f47774fe04b0d730d892e006" } |
There was a problem hiding this comment.
This is intentional. We'll update the shim package once we have properly signed 16.1 binaries.
| [components.shim-unsigned-aarch64] | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "43" }, upstream-commit = "67c1d520f9a8080f6b689714099f813f23154c8f" } | ||
| # Pin shim 16.1 to Fedora dist-git commit 4db14e5ed7d3bdb7fda97f62c93e612435f2cce9. | ||
| spec = { type = "upstream", upstream-distro = { name = "fedora", version = "44" }, upstream-commit = "4db14e5ed7d3bdb7fda97f62c93e612435f2cce9" } |
There was a problem hiding this comment.
This is intentional. We'll update the shim package once we have signed 16.1 binaries.
d41a56c to
5c32d59
Compare
| # Workaround: add dist tag to the release to avoid NEVR conflicts | ||
| # while we are still rebuilding all packages in new tags nightly. | ||
| { type = "spec-update-tag", tag = "Release", value = "2%{?dist}" }, | ||
| { type = "spec-update-tag", tag = "Release", value = "1%{?dist}" }, |
| # Workaround: add dist tag to the release to avoid NEVR conflicts | ||
| # while we are still rebuilding all packages in new tags nightly. | ||
| { type = "spec-update-tag", tag = "Release", value = "2%{?dist}" }, | ||
| { type = "spec-update-tag", tag = "Release", value = "1%{?dist}" }, |
Replace the Fedora Secure Boot CA with the Azure Linux CA in both unsigned shim packages.
5c32d59 to
69ef86d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 18 changed files in this pull request and generated 2 comments.
Suppressed comments (2)
base/comps/shim-unsigned-x64/shim-unsigned-x64.comp.toml:8
- This modified overlay still omits the required
descriptionfield. Add a concise description of the nightly-rebuild release workaround, then refresh the component lock because descriptions are part of the component input.
{ type = "spec-update-tag", tag = "Release", value = "1%{?dist}" },
base/comps/shim-unsigned-aarch64/shim-unsigned-aarch64.comp.toml:8
- This modified overlay still omits the required
descriptionfield. Add a concise description of the nightly-rebuild release workaround, then refresh the component lock because descriptions are part of the component input.
{ type = "spec-update-tag", tag = "Release", value = "1%{?dist}" },
| # Workaround: create a compat symlink that does not include the dist tag. | ||
| { type = "spec-append-lines", section = "%install", lines = ["ln -s %{version}-%{release} %{buildroot}%{_datadir}/shim/%{version}-2"] }, | ||
| { type = "spec-append-lines", section = "%files", lines = ["%{_datadir}/shim/%{version}-2"] } | ||
| { type = "spec-append-lines", section = "%files", lines = ["%{_datadir}/shim/%{version}-2"] }, |
| { type = "spec-append-lines", section = "%install", lines = ["ln -s %{version}-%{release} %{buildroot}%{_datadir}/shim/%{version}-2"] }, | ||
| { type = "spec-append-lines", section = "%files", lines = ["%{_datadir}/shim/%{version}-2"] } | ||
| { type = "spec-append-lines", section = "%files", lines = ["%{_datadir}/shim/%{version}-2"] }, |
No description provided.